Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where there were false positives in runpath check #8194

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jun 20, 2024

Issue
Resolves #8188

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. Good work on adding test 👍

@oyvindeide oyvindeide enabled auto-merge (rebase) June 21, 2024 07:04
@oyvindeide oyvindeide merged commit aadcb85 into equinor:version-10.1 Jun 21, 2024
38 checks passed
@oyvindeide oyvindeide deleted the backport_paths branch June 21, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants