Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix real mem doc #8837

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix real mem doc #8837

merged 2 commits into from
Oct 2, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 1, 2024

Issue
Resolves REALIZATION_MEMORY not listed in keyword overview table.

Approach

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added release-notes:skip If there should be no mention of this in release notes documentation labels Oct 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (9f8d73a) to head (6de07f9).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8837      +/-   ##
==========================================
+ Coverage   91.37%   91.40%   +0.02%     
==========================================
  Files         342      342              
  Lines       21028    21028              
==========================================
+ Hits        19215    19221       +6     
+ Misses       1813     1807       -6     
Flag Coverage Δ
cli-tests 39.62% <ø> (+0.01%) ⬆️
gui-tests 73.58% <ø> (ø)
performance-tests 50.05% <ø> (ø)
unit-tests 79.84% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@berland berland enabled auto-merge (rebase) October 2, 2024 05:21
@berland berland merged commit 4321e49 into main Oct 2, 2024
51 checks passed
@berland berland deleted the fix_real_mem_doc branch October 2, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants