Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure run dialog is closed in gui test #8841

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Oct 1, 2024

Ensure that the run dialog is closed in test_that_a_failing_job_shows_error_message_with_context

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.38%. Comparing base (9f8d73a) to head (b1e1d04).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8841   +/-   ##
=======================================
  Coverage   91.37%   91.38%           
=======================================
  Files         342      342           
  Lines       21028    21028           
=======================================
+ Hits        19215    19217    +2     
+ Misses       1813     1811    -2     
Flag Coverage Δ
cli-tests 39.62% <ø> (+0.01%) ⬆️
gui-tests 73.55% <ø> (-0.03%) ⬇️
performance-tests 50.09% <ø> (+0.03%) ⬆️
unit-tests 79.82% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren merged commit 523389f into equinor:main Oct 1, 2024
50 checks passed
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants