-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ensemble_size dynamically for each batch #9012
Set ensemble_size dynamically for each batch #9012
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9012 +/- ##
==========================================
+ Coverage 90.86% 90.96% +0.10%
==========================================
Files 349 352 +3
Lines 21621 21695 +74
==========================================
+ Hits 19645 19734 +89
+ Misses 1976 1961 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
827d39b
to
a52f1c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rebase the commits so you have the introducing of ConfigKeysErt completely separate from the changing of the default value, the commit with the test fixup now relates to both of these things, it would be nice to have it in sequence and not intermingled. Maybe a bit of a nitpick but I'm not sure about this practice of using these "string enums" in general to access the dicts.
That is a very good point. Should we really use these enums? Maybe we can discuss this in the standup. |
b1e2d6e
to
986cce5
Compare
Issue
Resolves #8848
Approach
Remove the default number of realizations and set it dynamically for each batch when a new ensemble is created. Also, for completeness still setting number of realizations equal to length of the realization list in the config file (in Ert AnalysisConfig and ModelConfig we still use the config dictionary and ConfigKeys.NUM_REALIZATIONS to set the num_realizations field). If we know how many realizations there are, why not set is correctly was my logic. Also cleaned up the hard coded strings by importing the Ert ConfigKeys.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable