Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InvalidResponseFile and FileNotFoundError part of read_from_file #9023

Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 23, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren marked this pull request as draft October 23, 2024 08:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 80.39216% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (e55b1f9) to head (4a0a85e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/callbacks.py 63.63% 4 Missing ⚠️
src/ert/config/gen_data_config.py 75.00% 4 Missing ⚠️
src/ert/config/_read_summary.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9023      +/-   ##
==========================================
- Coverage   90.98%   90.93%   -0.06%     
==========================================
  Files         352      352              
  Lines       21695    21712      +17     
==========================================
+ Hits        19740    19744       +4     
- Misses       1955     1968      +13     
Flag Coverage Δ
cli-tests 39.09% <35.29%> (-0.01%) ⬇️
gui-tests 72.66% <25.49%> (-0.08%) ⬇️
performance-tests 49.55% <25.49%> (-0.03%) ⬇️
unit-tests 79.66% <80.39%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren marked this pull request as ready for review October 23, 2024 08:46
@eivindjahren eivindjahren force-pushed the use_error_instead_of_exception branch from e34dcf5 to 4a0a85e Compare October 23, 2024 09:48
@eivindjahren eivindjahren requested a review from yngve-sk October 23, 2024 09:48
@eivindjahren eivindjahren self-assigned this Oct 23, 2024
@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 23, 2024
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, I tried running with poly with invalid/missing files and got correct warnings logged in event viewer.

Was a bit confused about the suppress-tests but it makes sense after looking at it a bit, so LGTM.

@eivindjahren eivindjahren merged commit 5fcf7d3 into equinor:main Oct 23, 2024
56 checks passed
@eivindjahren eivindjahren deleted the use_error_instead_of_exception branch October 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants