Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename job_dispatch -> fm_dispatch #9534

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Dec 13, 2024

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq self-assigned this Dec 13, 2024
@jonathan-eq jonathan-eq added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.87%. Comparing base (05b33a5) to head (efb6532).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/_ert/forward_model_runner/cli.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9534      +/-   ##
==========================================
+ Coverage   91.83%   91.87%   +0.03%     
==========================================
  Files         433      433              
  Lines       26748    26767      +19     
==========================================
+ Hits        24563    24591      +28     
+ Misses       2185     2176       -9     
Flag Coverage Δ
cli-tests 39.78% <50.00%> (+0.36%) ⬆️
everest-models-test 34.67% <50.00%> (-0.03%) ⬇️
gui-tests 72.13% <50.00%> (-0.03%) ⬇️
integration-test 37.23% <50.00%> (+0.28%) ⬆️
performance-tests 51.98% <50.00%> (+<0.01%) ⬆️
test 40.48% <50.00%> (-0.05%) ⬇️
unit-tests 74.14% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland
Copy link
Contributor

berland commented Dec 13, 2024

Check also this:

[../ert/docs] $ rg job_disp
ert/about/release_notes.rst
1076:  - Setup log file for job_dispatch logger (`#3999 <https://github.com/equinor/ert/pull/3999>`_)
1661:  - job_dispatch: Makedir in, out, err locations (`#2998 <https://github.com/equinor/ert/pull/2998>`_)
2528:  - Have job_dispatch propagate events to prepare for a new ensemble evaluator
2856:Add komodo_job_dispatch from equlibrium
3179: As part of this development cycle the job_dispatch script has been

ert/developer_documentation/roadmap.rst
68:should probably be propagated by the :code:`job_dispatch` to the rest of the system

ert/developer_documentation/forward_model.rst
36:this entails that the script :code:`job_dispatch.py` is executed with the runpath of

ert/reference/configuration/site_wide.rst
29:   JOB_SCRIPT ../../bin/job_dispatch.py

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9534 will improve performances by 60.57%

Comparing jonathan-eq:rename_job_dispatch (efb6532) with main (ebe548e)

Summary

⚡ 2 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark main jonathan-eq:rename_job_dispatch Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 7.1 ms 6.4 ms +11.5%
test_gui_snapshot 3.5 s 2.2 s +60.57%

@jonathan-eq
Copy link
Contributor Author

Check also this:

[../ert/docs] $ rg job_disp
ert/about/release_notes.rst
1076:  - Setup log file for job_dispatch logger (`#3999 <https://github.com/equinor/ert/pull/3999>`_)
1661:  - job_dispatch: Makedir in, out, err locations (`#2998 <https://github.com/equinor/ert/pull/2998>`_)
2528:  - Have job_dispatch propagate events to prepare for a new ensemble evaluator
2856:Add komodo_job_dispatch from equlibrium
3179: As part of this development cycle the job_dispatch script has been

ert/developer_documentation/roadmap.rst
68:should probably be propagated by the :code:`job_dispatch` to the rest of the system

ert/developer_documentation/forward_model.rst
36:this entails that the script :code:`job_dispatch.py` is executed with the runpath of

ert/reference/configuration/site_wide.rst
29:   JOB_SCRIPT ../../bin/job_dispatch.py

There is a reference to job_dispatch.py in equilibrium too

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@jonathan-eq jonathan-eq merged commit a95d0d2 into equinor:main Dec 19, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants