Include spans for dark storage #9535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HakonSohoel
force-pushed
the
Include-spans-for-dark-storage
branch
from
4958390 to
9d7ee1b
Compare
CodSpeed Performance ReportMerging #9535 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9535 +/- ##
==========================================
- Coverage 91.85% 91.74% -0.12%
==========================================
Files 433 426 -7
Lines 26768 26552 -216
==========================================
- Hits 24587 24359 -228
- Misses 2181 2193 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add opentelemetry.instrumentation on server and client side Fix azure log handler overriden by uvicorn.Config
This will include these log messages in azure
HakonSohoel
force-pushed
the
Include-spans-for-dark-storage
branch
from
2c3d8c9 to
e8d20e5
Compare
berland
changed the title
HakonSohoel
changed the title
eivindjahren
reviewed
Jan 9, 2025
| config_args.update(reload=True, reload_dirs=[os.path.dirname(ert_shared_path)]) | ||
| uvicorn_config = uvicorn.Config( | ||
| DARK_STORAGE_APP, **config_args | ||
| ) # Need to run uvicorn.Config before entering the ErtPluginContext because uvicorn.Config overrides the configuration of existing loggers, thus removing log handlers added by ErtPluginContext |
There was a problem hiding this comment.
This comment is a bit long, same with the one on line 119
eivindjahren
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves equinor/scout#1157
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable