Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty ensemble in observations view #9554

Merged

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Dec 16, 2024

Issue
Resolves #9549

image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (ebe548e) to head (83c5d95).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9554      +/-   ##
==========================================
+ Coverage   91.87%   91.88%   +0.01%     
==========================================
  Files         433      433              
  Lines       26767    26769       +2     
==========================================
+ Hits        24591    24598       +7     
+ Misses       2176     2171       -5     
Flag Coverage Δ
cli-tests 39.77% <0.00%> (-0.01%) ⬇️
everest-models-test 34.67% <0.00%> (+<0.01%) ⬆️
gui-tests 72.18% <100.00%> (+0.06%) ⬆️
integration-test 37.21% <0.00%> (-0.03%) ⬇️
performance-tests 51.97% <0.00%> (-0.01%) ⬇️
test 40.48% <0.00%> (-0.01%) ⬇️
unit-tests 74.16% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9554 will improve performances by 85.07%

Comparing yngve-sk:24.12.16.handle-empty-ens-edgecase-gui (83c5d95) with main (0d10c5d)

Summary

⚡ 1 improvements
✅ 22 untouched benchmarks

Benchmarks breakdown

Benchmark main yngve-sk:24.12.16.handle-empty-ens-edgecase-gui Change
test_gui_snapshot 3.6 s 1.9 s +85.07%

@yngve-sk yngve-sk force-pushed the 24.12.16.handle-empty-ens-edgecase-gui branch from 1336f40 to 06ad21a Compare December 16, 2024 12:12
@eivindjahren eivindjahren changed the title Handle empty ensemble edge case in gui Handle empty ensemble in observations view Dec 16, 2024
@eivindjahren eivindjahren added the release-notes:unreleased-bug-fix PR with a bug-fix of unreleased features label Dec 16, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regression test does not catch the bug.

@yngve-sk yngve-sk force-pushed the 24.12.16.handle-empty-ens-edgecase-gui branch from 06ad21a to 83c5d95 Compare December 16, 2024 13:31
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yngve-sk yngve-sk enabled auto-merge (rebase) December 16, 2024 13:36
@yngve-sk yngve-sk merged commit 4550d40 into equinor:main Dec 16, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:unreleased-bug-fix PR with a bug-fix of unreleased features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: FOPR is not a response from manage_experiments
3 participants