Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreliable benchmark: test_gui_snapshot #9566

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 16, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj requested a review from eivindjahren December 16, 2024 13:45
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Dec 16, 2024
@eivindjahren eivindjahren changed the title Remove unreliable test: test_gui_snapshot Remove unreliable benchmark: test_gui_snapshot Dec 16, 2024
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9566 will not alter performance

Comparing larsevj:remove_test_gui_snapshot (b59f341) with main (d4e7b72)

Summary

✅ 22 untouched benchmarks
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main larsevj:remove_test_gui_snapshot Change
⁉️ test_gui_snapshot 7.1 s N/A N/A

@larsevj larsevj merged commit 69535ab into equinor:main Dec 16, 2024
40 of 41 checks passed
@larsevj larsevj deleted the remove_test_gui_snapshot branch December 16, 2024 14:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (d4e7b72) to head (b59f341).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9566      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         433      433              
  Lines       26769    26763       -6     
==========================================
- Hits        24594    24586       -8     
- Misses       2175     2177       +2     
Flag Coverage Δ
cli-tests 39.77% <ø> (-0.01%) ⬇️
everest-models-test 34.66% <ø> (-0.01%) ⬇️
gui-tests 72.12% <ø> (+<0.01%) ⬆️
integration-test 37.21% <ø> (-0.01%) ⬇️
performance-tests 51.96% <ø> (-0.02%) ⬇️
test 40.46% <ø> (-0.01%) ⬇️
unit-tests 74.16% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants