Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad dunder method name #9571

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Bad dunder method name #9571

merged 2 commits into from
Dec 18, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Dec 17, 2024

Issue
Resolves ruff issue PLW3201

Approach
🧠

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (0e19012) to head (9b35a91).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9571      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         433      433              
  Lines       26770    26768       -2     
==========================================
- Hits        24595    24592       -3     
- Misses       2175     2176       +1     
Flag Coverage Δ
cli-tests 39.75% <ø> (-0.01%) ⬇️
everest-models-test 34.65% <ø> (-0.01%) ⬇️
gui-tests 72.14% <ø> (+<0.01%) ⬆️
integration-test 37.20% <ø> (+<0.01%) ⬆️
performance-tests 51.97% <ø> (+0.03%) ⬆️
test 40.44% <ø> (-0.01%) ⬇️
unit-tests 74.16% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #9571 will improve performances by 13.5%

Comparing bad-dunder-method-name (9b35a91) with main (0e19012)

Summary

⚡ 2 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark main bad-dunder-method-name Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 6.8 ms 6 ms +13.5%
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.4 ms 1.2 ms +11.38%

@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 18, 2024
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✈️

@berland berland merged commit 01156bb into main Dec 18, 2024
42 checks passed
@berland berland deleted the bad-dunder-method-name branch December 18, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants