-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple occurrences of design matrix #9583
Conversation
CodSpeed Performance ReportMerging #9583 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9583 +/- ##
=======================================
Coverage 91.73% 91.73%
=======================================
Files 426 426
Lines 26542 26567 +25
=======================================
+ Hits 24348 24372 +24
- Misses 2194 2195 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Add merging strategy for multiple design matrices in the config - Add ui tests for multi dm occurence
errors.append(ErrorInfo(f"Error when merging design matrices {exc}!")) | ||
|
||
pc_other = dm_other.parameter_configuration[DESIGN_MATRIX_GROUP] | ||
pc_self = self.parameter_configuration[DESIGN_MATRIX_GROUP] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it due to mypy that we go via pc_self
instead of just appending to self.parameter_configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Issue
Resolves #9532
Approach
All occurrences of design matrices will be merged into one upon initialization.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable