Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fm step configuration values to be empty strings #9584

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Dec 18, 2024

Issue
Resolves bug that can only be triggered through the plugin system

Approach
Detect empty string

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland
Copy link
Contributor Author

berland commented Dec 18, 2024

Changing the test to use hypothesis makes the test run for 12 seconds. Maybe it is better to skip hypothesis and just test some normal samples manually?

@berland berland added release-notes:maintenance Automatically categorise as maintenance change in release notes release-notes:unreleased-bug-fix PR with a bug-fix of unreleased features and removed release-notes:maintenance Automatically categorise as maintenance change in release notes labels Dec 18, 2024
@berland berland self-assigned this Dec 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (01156bb) to head (37653eb).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/config/ert_config.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9584   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files         433      433           
  Lines       26768    26770    +2     
=======================================
+ Hits        24587    24589    +2     
  Misses       2181     2181           
Flag Coverage Δ
cli-tests 39.76% <84.61%> (+<0.01%) ⬆️
everest-models-test 34.58% <84.61%> (+<0.01%) ⬆️
gui-tests 72.14% <84.61%> (+0.02%) ⬆️
integration-test 37.20% <84.61%> (+<0.01%) ⬆️
performance-tests 51.94% <84.61%> (-0.01%) ⬇️
test 40.44% <84.61%> (-0.01%) ⬇️
unit-tests 74.18% <92.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #9584 will degrade performances by 16.61%

Comparing berland:fm_config_empty (37653eb) with main (01156bb)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main berland:fm_config_empty Change
test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_parameters] 144 µs 172.7 µs -16.61%

@berland berland merged commit 2b41fe2 into equinor:main Dec 19, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:unreleased-bug-fix PR with a bug-fix of unreleased features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants