Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the bhist command to be temporarily unavailable #9687

Closed
wants to merge 2 commits into from

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 9, 2025

This makes the handling of a FileNotFoundError on bhist similar to the handling of FileNotFoundError from bjobs. It is important not to crash on potentially intermittent failures in code that is rerun every 2 seconds.

Issue
Resolves driver crash when filesystem is down temporarily. Observed in span-id 5d8f799c0d5fb127e4c7be3e56239a49

Approach
try-catch

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This makes the handling of a FileNotFoundError on bhist similar to the handling of
FileNotFoundError from bjobs. It is important not to crash on potentially intermittent
failures in code that is rerun every 2 seconds.
@berland berland added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 9, 2025
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #9687 will not alter performance

Comparing berland:allow_bhist_no_such_file (c930d3d) with main (3a31ffb)

Summary

✅ 24 untouched benchmarks

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better handling! 👍

@berland
Copy link
Contributor Author

berland commented Jan 9, 2025

Superseded by #9696

@berland berland closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants