Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pre_experiment validation has access to plugin configuration #9703

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 10, 2025

This is a fixup of a regression in 1ae12f6

The bug slipped through as the feature is skipped unless the test is run on-premise

Issue
Resolves #9702

Approach
+

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:unreleased-bug-fix PR with a bug-fix of unreleased features label Jan 10, 2025
@berland berland self-assigned this Jan 10, 2025
This is a fixup of a regression in 1ae12f6

The bug slipped through as the feature is skipped unless the test is
run on-premise
@berland berland force-pushed the fix_plugin_validation branch from 525cf00 to cf618e8 Compare January 10, 2025 09:31
@berland berland enabled auto-merge (rebase) January 10, 2025 09:31
Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #9703 will not alter performance

Comparing berland:fix_plugin_validation (cf618e8) with main (7b2bedf)

Summary

✅ 24 untouched benchmarks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (7b2bedf) to head (cf618e8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9703      +/-   ##
==========================================
+ Coverage   91.73%   91.75%   +0.02%     
==========================================
  Files         426      426              
  Lines       26535    26535              
==========================================
+ Hits        24342    24348       +6     
+ Misses       2193     2187       -6     
Flag Coverage Δ
cli-tests 39.81% <ø> (-0.01%) ⬇️
everest-models-test 34.16% <ø> (ø)
gui-tests 74.37% <ø> (+0.03%) ⬆️
integration-test 37.99% <ø> (ø)
performance-tests 51.59% <ø> (ø)
test 39.52% <ø> (ø)
unit-tests 74.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland merged commit 2a3f4f0 into equinor:main Jan 10, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:unreleased-bug-fix PR with a bug-fix of unreleased features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward model step configuration is not available to pre experiment validation
3 participants