Upgrade ruff in pre commit to 0.9.1

[larsevj]

Mainly formatting changes, there is also the change to PluginMetadate into a dataclass based on the following rule https://docs.astral.sh/ruff/rules/class-as-data-structure/, but could also ignore this rule if we want to.

• PR title captures the intent of the changes, and is fitting for release notes.
• Added appropriate release note label
• Commit history is consistent and clean, in line with the contribution guidelines.
• Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

• When there are user facing changes: Updated documentation
• New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
• Large PR: Prepare changes in small commits for more convenient review
• Bug fix: Add regression test for the bug
• Bug fix: Create Backport PR to latest release

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (ea36931) to head (21cc24a).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...rc/_ert/forward_model_runner/forward_model_step.py	0.00%	2 Missing ⚠️
src/ert/gui/suggestor/_suggestor_message.py	0.00%	1 Missing ⚠️
src/ert/gui/tools/workflows/run_workflow_widget.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9712      +/-   ##
==========================================
- Coverage   91.76%   91.72%   -0.05%     
==========================================
  Files         426      426              
  Lines       26542    26549       +7     
==========================================
- Hits        24356    24351       -5     
- Misses       2186     2198      +12     

Flag	Coverage Δ
cli-tests	39.78% <31.25%> (+0.01%)	⬆️
everest-models-test	34.14% <33.33%> (+0.01%)	⬆️
gui-tests	74.33% <50.00%> (-0.03%)	⬇️
integration-test	37.97% <33.33%> (+0.01%)	⬆️
performance-tests	51.57% <31.25%> (-0.01%)	⬇️
test	39.49% <38.88%> (+<0.01%)	⬆️
unit-tests	74.19% <66.66%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codspeed-hq]

CodSpeed Performance Report

Merging #9712 will not alter performance

_{Comparing larsevj:upgrade_ruff_in_pre_commit_to_9 (21cc24a) with main (051fa31)}

Summary

✅ 24 untouched benchmarks

[berland]

Looks good, but could you reverse the commit order to make every commit passing tests?

[larsevj]

Looks good, but could you reverse the commit order to make every commit passing tests?

I planned on squashing them, was just unsure if it was best to use NamedTuple or dataclass for the PluginMetadata class.

[berland]

wow!

[berland]

Is it worth another issue to track down why this was not caught in tests earlier?

[larsevj]

I will create another issue and fix it in a seperate pr aswell.

[berland]

Looks good, but could you reverse the commit order to make every commit passing tests?

I planned on squashing them, was just unsure if it was best to use NamedTuple or dataclass for the PluginMetadata class.

NamedTupe is fine