Use fetch-depth 1024 instead of 0 #9715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsevj
reviewed
Jan 13, 2025
| @@ -23,7 +23,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
Maybe set fetch-tags to true?
There was a problem hiding this comment.
Else you will get ert version 0.1
There was a problem hiding this comment.
Fixed by removing all together as this workflow does not depend on having the correct version.
eivindjahren
force-pushed
the
fix_fetch_depth
branch
3 times, most recently
from
c41b959 to
7db248e
Compare
eivindjahren
added
the
release-notes:maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9715 +/- ##
==========================================
- Coverage 91.73% 91.72% -0.01%
==========================================
Files 426 426
Lines 26542 26549 +7
==========================================
+ Hits 24348 24353 +5
- Misses 2194 2196 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9715 will not alter performanceComparing Summary
|
eivindjahren
force-pushed
the
fix_fetch_depth
branch
from
7db248e to
be1e448
Compare
This uses a bit of a hack for checking out with sub modules where we assume the latest version tag is no more than 1024 commits ago.
eivindjahren
force-pushed
the
fix_fetch_depth
branch
from
be1e448 to
7bd0c67
Compare
andreas-el
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack that assumes that git describe is correct with the last 1024 commits to save time.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable