Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up tests by reusing plugin manager #9740

Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 15, 2025

Saves ~35s of collecting plugins on my machine.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9740 will improve performances by 21.61%

Comparing eivindjahren:avoid_recreating_plugin_manager (6ad06b0) with main (024fcba)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark main eivindjahren:avoid_recreating_plugin_manager Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.5 ms 1.2 ms +21.61%

@eivindjahren eivindjahren self-assigned this Jan 15, 2025
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@eivindjahren eivindjahren force-pushed the avoid_recreating_plugin_manager branch from ee97a39 to 6ad06b0 Compare January 15, 2025 07:34
@eivindjahren eivindjahren enabled auto-merge (rebase) January 15, 2025 07:34
@eivindjahren eivindjahren merged commit 9a1002d into equinor:main Jan 15, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants