Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default flow simulator version to default #9744

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 15, 2025

daily is too on-premises specific, and will actually not work when the current version of ert-configurations is installed off-premise.

Issue
Resolves test failure off-premise with ert-configurations installed.

Approach
🧠

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

daily is too on-premises specific, and will actually not
work when the current version of ert-configurations is installed
off-premise.
@berland berland self-assigned this Jan 15, 2025
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9744 will improve performances by 10.51%

Comparing berland:default_flow_sim_tests (ba0d7a1) with main (024fcba)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark main berland:default_flow_sim_tests Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.5 ms 1.3 ms +10.51%

@berland berland merged commit 56b3381 into equinor:main Jan 15, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants