Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on full disk #9745

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Warn on full disk #9745

merged 2 commits into from
Jan 15, 2025

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 15, 2025

Issue
Resolves #8921

The following is presented if disk is "close" to full:
image

image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:improvement Automatically categorise as improvement in release notes label Jan 15, 2025
@eivindjahren
Copy link
Contributor Author

Supersedes #9193

@eivindjahren eivindjahren force-pushed the warn_on_full_disk branch 2 times, most recently from e39f1bc to 77b2851 Compare January 15, 2025 08:31
Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eivindjahren eivindjahren enabled auto-merge (rebase) January 15, 2025 08:43
@eivindjahren eivindjahren merged commit b6edc3b into equinor:main Jan 15, 2025
35 checks passed
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9745 will improve performances by 10.96%

Comparing eivindjahren:warn_on_full_disk (6004ec7) with main (56b3381)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark main eivindjahren:warn_on_full_disk Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 7.1 ms 6.4 ms +10.96%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider displaying the status of free disk spacefor runpath in the Ert gui
2 participants