Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change min realizations warning test from cli to unit #9747

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 15, 2025

Changes one simple cli test to a unit test. Avoids ~1 minute worth of run time.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9747 will not alter performance

Comparing eivindjahren:speed_up_cli_test (4bdc45d) with main (b6edc3b)

Summary

✅ 24 untouched benchmarks

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@eivindjahren eivindjahren merged commit 867aac3 into equinor:main Jan 15, 2025
36 checks passed
@eivindjahren eivindjahren deleted the speed_up_cli_test branch January 15, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants