-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dev documentation on everest vs ert data models #9820
Add dev documentation on everest vs ert data models #9820
Conversation
CodSpeed Performance ReportMerging #9820 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle correct. But some amendments.
Just a general remark: I am not happy with the use of |
Yes I completely agree, that's why I suggested in the description of the PR to change this name. However, since it is not changed in the code yet, I thought we should be consistent with what we currently have until we decide on a better name, like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, I think this looks really nice now, and feel like someone new to Everest/ERT could read this and get a better idea of what's going on. LGTM, I left some smaller comments I think you can address before merging.
8543d18
to
b0302e4
Compare
Issue
Resolves #9619
Approach
Attempts to clarify the differences between ERT and EVEREST data models. There are things in here that need revision (like the mapping, these equations work but not sure if it makes sense in all cases of optimization meaning gradient vs. derrivative free methods etc.). Also, with Yngve we suggest a couple of name changes:
simulation
->ert_realization
(at least in the code, since they are synonymous)geo_realization
->model_realization
(or justrealization
towards the user, we are not just concerned with GEO apps?)<GEO_ID>
- ><STATIC_MODEL_ID>
or<MODEL_REALIZATION_ID>
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"'
)When applicable