Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for flow vs OMP_NUM_THREADS #9834

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 22, 2025

This serves as documentation and verification of the current interplay between ert, the plugin configuration of ert and the flowrun wrapper, and the flow binary itself.

Issue
Relates to #8668

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This serves as documentation and verification of the
current interplay between ert, the plugin configuration of
ert and the flowrun wrapper, and the flow binary itself.
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Jan 22, 2025
@berland berland self-assigned this Jan 22, 2025
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9834 will not alter performance

Comparing berland:flow_omp_num_threads_testing (9de4aac) with main (15109bb)

Summary

✅ 24 untouched benchmarks

@berland berland merged commit 45d87c3 into equinor:main Jan 22, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants