Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IES #9843

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Remove IES #9843

merged 1 commit into from
Jan 23, 2025

Conversation

sondreso
Copy link
Collaborator

@sondreso sondreso commented Jan 22, 2025

Issue
The Iterative Ensemble Smoother (IES) is sensitive to failing realizations and deactivation of observations. It's usage is not widespread, and in most cases ES-MDA is the preferred alternative. We will remove IES from ERT, but we will keep the implementation of the algorithm in the iterative_ensemble_smoother
repository.

Approach
Remove IES from ERT ✂️

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9843 will improve performances by 14.34%

Comparing sondreso:remove-ies (b628585) with main (905fb9a)

Summary

⚡ 2 improvements
✅ 22 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 7.2 ms 6.4 ms +12.29%
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.4 ms 1.2 ms +14.34%

@sondreso sondreso added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Jan 22, 2025
@sondreso sondreso marked this pull request as ready for review January 22, 2025 13:46
src/ert/analysis/_es_update.py Outdated Show resolved Hide resolved
src/ert/config/parsing/analysis_mode.py Outdated Show resolved Hide resolved
@sondreso sondreso force-pushed the remove-ies branch 2 times, most recently from 7fc55a1 to 4af7097 Compare January 22, 2025 14:33
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sondreso sondreso enabled auto-merge (rebase) January 23, 2025 08:54
@sondreso sondreso merged commit b7aa307 into equinor:main Jan 23, 2025
33 checks passed
@sondreso sondreso deleted the remove-ies branch January 23, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants