Consolidate optimizer options and backend_options #9887
Conversation
CodSpeed Performance ReportMerging #9887 will degrade performances by 10.42%Comparing Summary
Benchmarks breakdown
|
yngve-sk
force-pushed
the
25.01.28.consolidate-backendoptionsandoptions
branch
from
9c42031 to
8b58f7e
Compare
| if backend == "dakota": | ||
| alg_const_tol = ever_opt.constraint_tolerance or None | ||
| if has_output_constraints and alg_const_tol is not None: | ||
| options += [f"constraint_tolerance = {alg_const_tol}"] |
There was a problem hiding this comment.
Seems to only be for strs beforehand, should it also be for dicts?
There was a problem hiding this comment.
We do have a problem here. That constraint_tolerance line is dakota specific, so we should only add it if the backend is dakota. For now, do indeed just add it when the options are a list. Not for dicts.
yngve-sk
force-pushed
the
25.01.28.consolidate-backendoptionsandoptions
branch
3 times, most recently
from
ab45054 to
b29f041
Compare
| if backend == "dakota": | ||
| alg_const_tol = ever_opt.constraint_tolerance or None | ||
| if has_output_constraints and alg_const_tol is not None: | ||
| options += [f"constraint_tolerance = {alg_const_tol}"] |
There was a problem hiding this comment.
We do have a problem here. That constraint_tolerance line is dakota specific, so we should only add it if the backend is dakota. For now, do indeed just add it when the options are a list. Not for dicts.
yngve-sk
force-pushed
the
25.01.28.consolidate-backendoptionsandoptions
branch
from
b29f041 to
a10422e
Compare
Issue
Resolves #9772
Approach
Pass string to dakota, otherwise pass a dict.