-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send resubmit event to evaluator to reset snapshot #9888
Send resubmit event to evaluator to reset snapshot #9888
Conversation
CodSpeed Performance ReportMerging #9888 will improve performances by 11.52%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good improvement
31e4303
to
c4015c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a very good change. Good job! ☔ 🌦️
Instead of trying to loop over and check for consistency of the snapshots on the gui side we instead send a event when we resubmit a job indicating to the evaluator that the snapshot should be cleared.
git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"'
)When applicable