Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send resubmit event to evaluator to reset snapshot #9888

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Jan 28, 2025

Instead of trying to loop over and check for consistency of the snapshots on the gui side we instead send a event when we resubmit a job indicating to the evaluator that the snapshot should be cleared.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq self-requested a review January 28, 2025 11:21
Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #9888 will improve performances by 11.52%

Comparing larsevj:send_event_on_resubmit_of_realization (c4015c6) with main (cb0726d)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_observations] 2.7 ms 2.4 ms +11.52%

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good improvement

@larsevj larsevj added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 28, 2025
@larsevj larsevj force-pushed the send_event_on_resubmit_of_realization branch from 31e4303 to c4015c6 Compare January 29, 2025 08:57
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a very good change. Good job! ☔ 🌦️

@larsevj larsevj merged commit 79bdf82 into equinor:main Jan 29, 2025
27 checks passed
@larsevj larsevj deleted the send_event_on_resubmit_of_realization branch January 29, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants