Merge fm_dispatch.py and cli.py #9966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
the
release-notes:refactor
CodSpeed Performance ReportMerging #9966 will improve performances by 10.84%Comparing Summary
Benchmarks breakdown
|
berland
force-pushed
the
rm_cli_dot_py
branch
2 times, most recently
from
83d47b7 to
ca681b5
Compare
eivindjahren
reviewed
Feb 5, 2025
| from _ert.forward_model_runner.runner import ForwardModelRunner | ||
|
|
||
| FORWARD_MODEL_DESCRIPTION_FILE = ( | ||
| "jobs.json" # This is wrongly named, but must be kept for backwards compatibility |
There was a problem hiding this comment.
"wrongly" -> "incorrectly" ?
eivindjahren
reviewed
Feb 5, 2025
| fm_runner_logger.setLevel(logging.DEBUG) | ||
|
|
||
|
|
||
| NFS_FILE_RETRY_TIME = 30 |
There was a problem hiding this comment.
Maybe FM_DESCRIPTION_RETRY_TIME ? I guess this race condition could happen on other file systems also. Could maybe have a small comment.
eivindjahren
approved these changes
Feb 5, 2025
No need to keep in separate files
berland
force-pushed
the
rm_cli_dot_py
branch
from
ca681b5 to
a7eb918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to keep in separate files
Issue
Resolves unneeded file split
Approach
⌨️
git rebase -i main --exec 'just rapid-tests')When applicable