Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unstuck main #9968

Merged
merged 3 commits into from
Feb 5, 2025
Merged

unstuck main #9968

merged 3 commits into from
Feb 5, 2025

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Feb 5, 2025

Forgot to rebase on 2a53a93

DanSava
DanSava approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9968 will degrade performances by 14.33%

Comparing yngve-sk:25.02.05.debug-snapshot-change (c542f2c) with main (e1f4eab)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.3 ms 1.6 ms -14.33%

@yngve-sk yngve-sk force-pushed the 25.02.05.debug-snapshot-change branch from f1e039e to 839fc33 Compare February 5, 2025 12:08
@yngve-sk yngve-sk mentioned this pull request Feb 5, 2025
Closed
@yngve-sk yngve-sk changed the title Update ropt config snapshots unstuck main Feb 5, 2025
@yngve-sk yngve-sk enabled auto-merge (rebase) February 5, 2025 12:20
@yngve-sk yngve-sk disabled auto-merge February 5, 2025 12:27
@yngve-sk yngve-sk enabled auto-merge (rebase) February 5, 2025 12:28
@yngve-sk yngve-sk merged commit 978727e into equinor:main Feb 5, 2025
26 checks passed
@sondreso sondreso mentioned this pull request Feb 10, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanSava DanSava DanSava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yngve-sk @DanSava