Ensure missions don't start on deprecated robot

equinor · Apr 2, 2024 · 2dc1884 · 2dc1884
1 parent 7bbba8c
commit 2dc1884
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/backend/api/Controllers/RobotController.cs b/backend/api/Controllers/RobotController.cs
@@ -638,6 +638,14 @@ [FromRoute] string armPosition
                 logger.LogWarning("{Message}", errorMessage);
                 return Conflict(errorMessage);
             }
+
+            if (robot.Deprecated)
+            {
+                string errorMessage = $"Robot {robotId} is deprecated ({robot.Status}) and cannot run missions";
+                logger.LogWarning("{Message}", errorMessage);
+                return Conflict(errorMessage);
+            }
+
             try { await isarService.StartMoveArm(robot, armPosition); }
             catch (HttpRequestException e)
             {

diff --git a/backend/api/Services/LocalizationService.cs b/backend/api/Services/LocalizationService.cs
@@ -75,6 +75,12 @@ public async Task<MissionRun> CreateLocalizationMissionInArea(string robotId, st
                 logger.LogWarning("{Message}", errorMessage);
                 throw new RobotNotAvailableException(errorMessage);
             }
+            if (robot.Deprecated)
+            {
+                string errorMessage = $"Robot '{robot.Id}' is deprecated and cannot localize";
+                logger.LogWarning("{Message}", errorMessage);
+                throw new RobotNotAvailableException(errorMessage);
+            }
 
             var localizationMissionRun = new MissionRun
             {

diff --git a/backend/api/Services/MissionSchedulingService.cs b/backend/api/Services/MissionSchedulingService.cs
@@ -339,6 +339,13 @@ private async Task StartMissionRun(MissionRun queuedMissionRun)
                 throw new RobotNotAvailableException(errorMessage);
             }
 
+            if (robot.Deprecated)
+            {
+                string errorMessage = $"Robot {robotId} is deprecated and cannot start mission";
+                logger.LogError("{Message}", errorMessage);
+                throw new RobotNotAvailableException(errorMessage);
+            }
+
             var missionRun = await missionRunService.ReadById(missionRunId);
             if (missionRun == null)
             {