Scroll to correct robot when scheduling mission

equinor · Nov 27, 2024 · 7778f3c · 7778f3c
1 parent f42b338
commit 7778f3c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/frontend/src/components/Pages/FrontPage/MissionOverview/MissionControlSection.tsx b/frontend/src/components/Pages/FrontPage/MissionOverview/MissionControlSection.tsx
@@ -9,6 +9,7 @@ import { useMissionsContext } from 'components/Contexts/MissionRunsContext'
 import { MissionHistoryButton } from './MissionHistoryButton'
 import { Robot } from 'models/Robot'
 import { RobotMissionQueueView } from './MissionQueueView'
+import { FrontPageSectionId } from 'models/FrontPageSectionId'
 
 const MissionControlStyle = styled.div`
     display: flex;

diff --git a/frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx b/frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx
@@ -6,7 +6,6 @@ import { useLanguageContext } from 'components/Contexts/LanguageContext'
 import { useMissionsContext } from 'components/Contexts/MissionRunsContext'
 import { AlertType, useAlertContext } from 'components/Contexts/AlertContext'
 import { FailedRequestAlertContent, FailedRequestAlertListContent } from 'components/Alerts/FailedRequestAlert'
-import { FrontPageSectionId } from 'models/FrontPageSectionId'
 import { AlertCategory } from 'components/Alerts/AlertsBanner'
 import { Robot } from 'models/Robot'
 import { tokens } from '@equinor/eds-tokens'
@@ -72,7 +71,7 @@ export const RobotMissionQueueView = ({ robot }: { robot: Robot }): JSX.Element
     return (
         <>
             {(robotMissionQueue.length > 0 || loadingMissionSet.size > 0) && (
-                <StyledMissionView id={FrontPageSectionId.MissionQueue}>
+                <StyledMissionView>
                     {missionQueueDisplay}
                     {loadingMissionSet.size > 0 && loadingQueueDisplay}
                 </StyledMissionView>

diff --git a/frontend/src/components/Pages/InspectionPage/ScheduleMissionDialogs.tsx b/frontend/src/components/Pages/InspectionPage/ScheduleMissionDialogs.tsx
@@ -115,11 +115,11 @@ export const ScheduleMissionDialog = (props: IProps): JSX.Element => {
         })
 
         if (missionsToSchedule.length > 0) {
-            let missionQueue = document.getElementById(FrontPageSectionId.MissionQueue)
+            let robotCard = document.getElementById(FrontPageSectionId.RobotCard + selectedRobot.id)
             let topBarHeight = document.getElementById(FrontPageSectionId.TopBar)?.offsetHeight ?? 0
 
-            if (missionQueue) {
-                window.scroll({ top: missionQueue.offsetTop - topBarHeight, behavior: 'smooth' })
+            if (robotCard) {
+                window.scroll({ top: robotCard.offsetTop - topBarHeight, behavior: 'smooth' })
             }
         }
 

diff --git a/frontend/src/models/FrontPageSectionId.ts b/frontend/src/models/FrontPageSectionId.ts
@@ -1,5 +1,5 @@
 export enum FrontPageSectionId {
     TopBar = 'topBar',
-    MissionQueue = 'missionQueue',
+    RobotCard = 'robotCard',
     InspectionTable = 'inspectionTable',
 }