Refactor and add guard statement in MissionEventHandler

equinor · Feb 16, 2024 · d9c2a1a · d9c2a1a
1 parent 0938c69
commit d9c2a1a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/backend/api/EventHandlers/MissionEventHandler.cs b/backend/api/EventHandlers/MissionEventHandler.cs
@@ -148,12 +148,9 @@ private async void OnRobotAvailable(object? sender, RobotAvailableEventArgs e)
                 return;
             }
 
-            MissionRun? missionRun;
+            var missionRun = await MissionService.ReadNextScheduledLocalizationMissionRun(robot.Id);
 
-            missionRun = await MissionService.ReadNextScheduledLocalizationMissionRun(robot.Id);
-
-            if (missionRun != null) { _logger.LogInformation("The robot will be localized in the next mission"); }
-            else
+            if (missionRun == null)
             {
                 if (robot.MissionQueueFrozen) { missionRun = await MissionService.ReadNextScheduledEmergencyMissionRun(robot.Id); }
                 else { missionRun = await MissionService.ReadNextScheduledMissionRun(robot.Id); }

diff --git a/backend/api/Services/LocalizationService.cs b/backend/api/Services/LocalizationService.cs
@@ -201,7 +201,6 @@ private async Task<MissionRun> CreateLocalizationMissionInArea(string robotId, s
                     new(area.Deck.DefaultLocalizationPose.Pose, MissionTaskType.Localization)
                 },
                 Map = new MapMetadata()
-
             };
             logger.LogWarning("Starting localization mission");
             await missionRunService.Create(localizationMissionRun, triggerCreatedMissionRunEvent: false);