Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store custom missions in SQL table instead of blob storage #1577

Closed
Tracked by #1575
andchiind opened this issue May 2, 2024 · 1 comment · Fixed by #1693
Closed
Tracked by #1575

Store custom missions in SQL table instead of blob storage #1577

andchiind opened this issue May 2, 2024 · 1 comment · Fixed by #1693
Assignees
Labels
backend Backend related functionality database-change Will require migration improvement Improvement to existing functionality stale This issue or pull request already exists

Comments

@andchiind
Copy link
Contributor

Describe the improvement you would like to see
Instead of storing and reading custom missions as JSONs in blob storage, make a new table which contains a string of the missions as a JSON, as well as the hash of the mission. Then we can look up the hash of the current mission we are uploading to check if it already has a record, and otherwise we make a new record.

How will this change existing functionality?
We would remove any reference to Azure blob storage, making it easier to use for other developers.

How will this improvement affect the current Threat Model?
It will remove another dependency which might improve the Threat Model.

@andchiind andchiind added backend Backend related functionality improvement Improvement to existing functionality database-change Will require migration labels May 2, 2024
@andchiind andchiind self-assigned this May 2, 2024
@aeshub
Copy link
Contributor

aeshub commented Jul 6, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality database-change Will require migration improvement Improvement to existing functionality stale This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants