Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display failure reason for failed steps #757

Open
Eddasol opened this issue Apr 19, 2023 · 8 comments
Open

Display failure reason for failed steps #757

Eddasol opened this issue Apr 19, 2023 · 8 comments
Labels
feature New feature or request frontend Frontend related functionality good first issue Good for newcomers stale This issue or pull request already exists

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Apr 19, 2023

Describe the new feature you would like to see
ISAR, through equinor/isar#457, will start sending error messages for missions, tasks and steps during the progress of the mission. Through #871 these MQTT messages will be picked up and stored in the mission, task and step models.

  • These error descriptions should be presented in the frontend
  • For example, a notice on each task could indicate what was the error description for that task
  • One task might have an error while the others are successful
  • Could be a popover when hovering over a failed icon (remember to be pad friendly)

Note the discussion in #871 where it might be that the error description should not be shown directly in the frontend, but rather a defined user facing message could be shown based on the error reason field.

Describe the solution you'd like
The end result of this issue should be that the error messages passed on from ISAR and stored by #871 are displayed in a meaningful way to the users.

How will this feature affect the current Threat Model?
Improved as users will be able to help debug the application and easily give feedback to developers.

@Eddasol Eddasol added the feature New feature or request label Apr 19, 2023
@aeshub
Copy link
Contributor

aeshub commented May 1, 2023

This is already in progress through this issue equinor/isar#457

The design choice changed a little so on hold while I'm travelling but will be continued afterwards.

@Christdej Christdej added the ux Issue needs input from UX designer label May 8, 2023
@aeshub
Copy link
Contributor

aeshub commented Jun 19, 2023

equinor/isar#457 has now been implemented and this issue may be addressed in the frontend.

@mariannewiggen
Copy link

mariannewiggen commented Aug 1, 2023

Suggest putting the error messages in the status column in the overview of the missions and adding a "Read more" button if the error message is longer than three lines.

Link to figma sketches: https://www.figma.com/file/q6vsNRogzV6r9vTCCDsocd/Robot-Missions?type=design&node-id=4635%3A618997&mode=design&t=kfBOLaxRlmNfzIr3-1

Image
Image

@mariannewiggen
Copy link

It is also possible to update the map with a red color corresponding to statuses that have failed. But perhaps it will be a bit much and that it will be associated with danger, which is in most cases not true

Link to figma: https://www.figma.com/file/q6vsNRogzV6r9vTCCDsocd/Robot-Missions?type=design&node-id=4637%3A632652&mode=design&t=b4SOdQXbJVojHvX7-1

Image

@aeshub
Copy link
Contributor

aeshub commented Oct 1, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Oct 1, 2023
@oysand oysand removed the stale This issue or pull request already exists label Oct 2, 2023
@oysand oysand added frontend Frontend related functionality and removed ux Issue needs input from UX designer labels Oct 16, 2023
@aeshub
Copy link
Contributor

aeshub commented Dec 19, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Dec 19, 2023
@aeshub aeshub removed the stale This issue or pull request already exists label Jan 15, 2024
@aeshub
Copy link
Contributor

aeshub commented May 5, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label May 5, 2024
@andchiind andchiind added good first issue Good for newcomers and removed stale This issue or pull request already exists labels Jul 25, 2024
@haakonsf haakonsf assigned haakonsf and unassigned haakonsf Jul 26, 2024
@aeshub
Copy link
Contributor

aeshub commented Sep 28, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request frontend Frontend related functionality good first issue Good for newcomers stale This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

7 participants