Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store error reasons for mission, task and step #871

Open
aeshub opened this issue Jun 23, 2023 · 7 comments
Open

Store error reasons for mission, task and step #871

aeshub opened this issue Jun 23, 2023 · 7 comments
Labels
backend Backend related functionality feature New feature or request stale This issue or pull request already exists

Comments

@aeshub
Copy link
Contributor

aeshub commented Jun 23, 2023

Describe the new feature you would like to see
After the implementation of equinor/isar#457 ISAR will now include an error description with the MQTT messages that are sent when the status for a mission, task or step is updated. The MQTT message contains two fields

  1. ErrorDescription (This contains a log message with some detailed information about what went wrong)
  2. ErrorReason (This points to the type of exception which was raised in ISAR to cause this error)

Flotilla should

It might be that the ErrorDescription should just be stored on the mission while the ErrorReason is used as an error code which translates into a default message for that type of error. For example

  • The ErrorReason is "robot_communication_exception"
  • The ErrorDescription is "Failed to schedule step {id} because: Unable to communicate with robot"
  • The user facing description for ErrorReason "robot_communication_exception" could be " The step failed as the system was not able to communicate with the robot"

Note that the frontend part of this issue is covered by #757

Describe the solution you'd like
The end result of this issue should be that the information from ISAR messages are stored on the mission, task and step models such that #757 may implement the user facing error feedback.

How will this feature affect the current Threat Model?

  • Should constitute a great improvement in error feedback to users which again will enable us to quicker identify issues which might also affect the threat model.
@aeshub aeshub added feature New feature or request backend Backend related functionality labels Jun 23, 2023
@andchiind andchiind self-assigned this Jul 18, 2023
@andchiind
Copy link
Contributor

Storing this internal information on the database objects might mean that we need to create a new DTO for the mission controller endpoint, so that these errors are not exposed when retrieving missions with GET requests. We are currently returning the Mission data without any editing. Unless we want to assume that this is open information to anyone who can call the endpoints.

@andchiind andchiind removed their assignment Sep 4, 2023
@aeshub
Copy link
Contributor Author

aeshub commented Sep 17, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Sep 17, 2023
@oysand
Copy link
Contributor

oysand commented Oct 2, 2023

Issue completed

@oysand oysand closed this as completed Oct 2, 2023
@oysand oysand removed the stale This issue or pull request already exists label Oct 2, 2023
@andchiind
Copy link
Contributor

It doesn't seem as if this issue has been completed, as the errors are not being received in Flotilla from Isar, so I'm reopening this

@andchiind andchiind reopened this Oct 17, 2023
@aeshub
Copy link
Contributor Author

aeshub commented Dec 19, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Dec 19, 2023
@aeshub aeshub removed the stale This issue or pull request already exists label Jan 15, 2024
@aeshub
Copy link
Contributor Author

aeshub commented May 5, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label May 5, 2024
@Christdej Christdej removed the stale This issue or pull request already exists label Aug 5, 2024
@aeshub
Copy link
Contributor Author

aeshub commented Oct 10, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality feature New feature or request stale This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants