-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store error reasons for mission, task and step #871
Comments
Storing this internal information on the database objects might mean that we need to create a new DTO for the mission controller endpoint, so that these errors are not exposed when retrieving missions with GET requests. We are currently returning the Mission data without any editing. Unless we want to assume that this is open information to anyone who can call the endpoints. |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
Issue completed |
It doesn't seem as if this issue has been completed, as the errors are not being received in Flotilla from Isar, so I'm reopening this |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
Describe the new feature you would like to see
After the implementation of equinor/isar#457 ISAR will now include an error description with the MQTT messages that are sent when the status for a mission, task or step is updated. The MQTT message contains two fields
ErrorDescription
(This contains a log message with some detailed information about what went wrong)ErrorReason
(This points to the type of exception which was raised in ISAR to cause this error)Flotilla should
ErrorDescription
andErrorReason
as fields on the respective models for mission, task and step when an MQTT message is collected (see here https://github.com/equinor/flotilla/blob/main/backend/api/EventHandlers/MqttEventHandler.cs#L350-L386 for how we currently update the status of a task)ErrorReason
It might be that the
ErrorDescription
should just be stored on the mission while theErrorReason
is used as an error code which translates into a default message for that type of error. For exampleErrorReason
is "robot_communication_exception"ErrorDescription
is "Failed to schedule step {id} because: Unable to communicate with robot"ErrorReason
"robot_communication_exception" could be " The step failed as the system was not able to communicate with the robot"Note that the frontend part of this issue is covered by #757
Describe the solution you'd like
The end result of this issue should be that the information from ISAR messages are stored on the mission, task and step models such that #757 may implement the user facing error feedback.
How will this feature affect the current Threat Model?
The text was updated successfully, but these errors were encountered: