Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the task counter on the ongoing mission card show ongoing mission number instead of completed tasks? #909

Closed
anetteu opened this issue Jul 23, 2023 · 4 comments · Fixed by #1118
Assignees
Labels
frontend Frontend related functionality good first issue Good for newcomers improvement Improvement to existing functionality

Comments

@anetteu
Copy link
Member

anetteu commented Jul 23, 2023

Describe the bug
On the ongoing mission card on the front page, there is a task counter Task 2/3 that shows the number of completed tasks. It is, however, understood as the ongoing task number by several users. It should be considered to show the ongoing task number instead of number of completed task, such that it will show Task 2/3 during execution of task 2 etc.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.
IMG_0032

@anetteu anetteu added bug Something isn't working frontend Frontend related functionality improvement Improvement to existing functionality and removed bug Something isn't working labels Jul 23, 2023
@anetteu anetteu changed the title Current task number on ongoing mission card shows number of completed tasks, not ongoing task number Should the task counter on the ongoing mission card show ongoing mission number instead of completed tasks? Jul 23, 2023
@andchiind
Copy link
Contributor

The main issue may be the ordering of the mission tasks themselves. If we fix this then this is no longer an issue.

@anetteu
Copy link
Member Author

anetteu commented Jul 27, 2023

The main issue may be the ordering of the mission tasks themselves. If we fix this then this is no longer an issue.

I am not sure if there is an issue here, I am just questioning what this counter should show. At the moment it is implemented to show number of completed tasks. I suggest to change the implementation to show the task number of the ongoing task, as that is how it is understand by several of the users.

@aeshub
Copy link
Contributor

aeshub commented Sep 26, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Sep 26, 2023
@oysand oysand added good first issue Good for newcomers and removed stale This issue or pull request already exists labels Oct 2, 2023
@oysand
Copy link
Contributor

oysand commented Oct 2, 2023

Consider just calling it completed tasks to avoid ambiguity? (Given that there is enough space) the text could be placed above same as with status to the left of it.

@anetteu anetteu self-assigned this Nov 5, 2023
@anetteu anetteu linked a pull request Nov 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend related functionality good first issue Good for newcomers improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants