Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle ongoing mission card #1118

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Restyle ongoing mission card #1118

merged 3 commits into from
Nov 9, 2023

Conversation

anetteu
Copy link
Member

@anetteu anetteu commented Nov 5, 2023

Solves #909

  • Implementation as suggested by @oysand in the issue.
  • Some refactor to the display components on the ongoing mission card

Current status:
Screenshot from 2023-11-05 08-59-33

Text components could be aligned better? Looks a bit messy. Frontend experts please help :)

@anetteu anetteu force-pushed the update-ongoing-mission-card branch from 00b8d32 to 840735c Compare November 5, 2023 09:07
@anetteu anetteu linked an issue Nov 5, 2023 that may be closed by this pull request
Consider to place pause and stop button in fixed position #901
Closed
@anetteu anetteu removed a link to an issue Nov 5, 2023
Consider to place pause and stop button in fixed position #901
Closed
@anetteu anetteu linked an issue Nov 5, 2023 that may be closed by this pull request
Should the task counter on the ongoing mission card show ongoing mission number instead of completed tasks? #909
Closed
@Eddasol Eddasol added improvement Improvement to existing functionality frontend Frontend related functionality labels Nov 6, 2023
@anetteu anetteu force-pushed the update-ongoing-mission-card branch from 840735c to 48bf2c0 Compare November 8, 2023 15:20
@anetteu anetteu self-assigned this Nov 8, 2023
@anetteu anetteu force-pushed the update-ongoing-mission-card branch 2 times, most recently from 1fa3298 to a2e9d11 Compare November 8, 2023 16:28
@anetteu anetteu requested a review from Eddasol November 8, 2023 16:29
@anetteu anetteu force-pushed the update-ongoing-mission-card branch from a2e9d11 to 4fcfe27 Compare November 9, 2023 08:07
@anetteu anetteu requested a review from Eddasol November 9, 2023 08:13
Eddasol
Eddasol approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Eddasol Eddasol mentioned this pull request Nov 9, 2023
Merged
@anetteu anetteu force-pushed the update-ongoing-mission-card branch from 4fcfe27 to 3bc5388 Compare November 9, 2023 12:58
@anetteu anetteu merged commit 3aa91e2 into equinor:main Nov 9, 2023
9 checks passed
@anetteu anetteu deleted the update-ongoing-mission-card branch November 9, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol approved these changes

Assignees

@anetteu anetteu

Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should the task counter on the ongoing mission card show ongoing mission number instead of completed tasks?
2 participants
@anetteu @Eddasol