Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/redesign robot page for when its offline #932

Closed
UsamaEquinorAFK opened this issue Aug 3, 2023 · 4 comments
Closed

Fix/redesign robot page for when its offline #932

UsamaEquinorAFK opened this issue Aug 3, 2023 · 4 comments
Labels
frontend Frontend related functionality improvement Improvement to existing functionality ux Issue needs input from UX designer

Comments

@UsamaEquinorAFK
Copy link
Contributor

UsamaEquinorAFK commented Aug 3, 2023 •
edited
Loading

Describe the improvement

Right now, if the Robot is offline, the robot card is still "clickable" and the user can access the robot page.

1- Should it be accessible ?
2- If yes, Should it have the localize button visible on an offline robot ?
3- If yes to both above, what should the robot page for an offline robot look like in general - do we have a design on figma or is it something we should discuss over ? @mariannewiggen

How will it affect the existing functionality

It will make it more clear for users to understand that the robot is offline - wont really affect anything else I think.

Does it affects the threat model

Not that I can think of.

Image attached below for reference
@UsamaEquinorAFK
Copy link
Contributor Author

UsamaEquinorAFK commented Aug 3, 2023 •
edited
Loading

Image

@UsamaEquinorAFK
Copy link
Contributor Author

Identified improvement while working on this PR #930

@UsamaEquinorAFK UsamaEquinorAFK mentioned this issue Aug 3, 2023
Merged
@UsamaEquinorAFK UsamaEquinorAFK added improvement Improvement to existing functionality frontend Frontend related functionality ux Issue needs input from UX designer labels Aug 3, 2023
@UsamaEquinorAFK UsamaEquinorAFK mentioned this issue Aug 3, 2023
Closed
@aeshub
Copy link
Contributor

aeshub commented Oct 2, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Oct 2, 2023
@oysand oysand removed the stale This issue or pull request already exists label Oct 2, 2023
@oysand
Copy link
Contributor

oysand commented Oct 2, 2023

The disabling of the localization button will not be needed after #950

@oysand oysand closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Frontend related functionality improvement Improvement to existing functionality ux Issue needs input from UX designer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aeshub @oysand @UsamaEquinorAFK