Fail mission when ISAR connection is lost #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
added
bug
andchiind
force-pushed
the
1044-bad-gateway
branch
2 times, most recently
from
933f2ce to
7780f55
Compare
aeshub
reviewed
Oct 18, 2023
aeshub
reviewed
Oct 18, 2023
andchiind
force-pushed
the
1044-bad-gateway
branch
from
979428a to
d350912
Compare
andchiind
force-pushed
the
1044-bad-gateway
branch
from
5ceadf4 to
786926d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1044
This PR fixes stopping the ongoing mission when connection to ISAR is lost, as well as an error that occurs when ISAR is started again. Errors were occuring since db context objects were taken out of scoped services and then used again from hosted services, which causes database errors since they are unable to verify that the object being modified is the same as before.
We still get a failed POST if we stop the mission as soon as we lose ISAR connection. I would like to create a banner alert for this, but I will then first wait for the failed request alert banner PR to be merged #1018 .