Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve appearance of mission definition page #1055

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Improve appearance of mission definition page #1055

merged 7 commits into from
Nov 8, 2023

Conversation

andchiind
Copy link
Contributor

Closes #944 since I haven't been able to find any issues with the functionality. This PR therefore just addresses appearances. These may change in the future as we get feedback from UX design, but this PR regardless makes it easier to edit this style in the future if needed.

@andchiind andchiind added improvement Improvement to existing functionality frontend Frontend related functionality labels Oct 13, 2023
@andchiind andchiind self-assigned this Oct 13, 2023
@andchiind andchiind force-pushed the 944-set-inspection-freq branch from 0991394 to 9037adb Compare October 13, 2023 08:57
@andchiind andchiind force-pushed the 944-set-inspection-freq branch 2 times, most recently from 89bf499 to 8ac7aee Compare October 16, 2023 09:02
@andchiind
Copy link
Contributor Author

This is how the page looks at the moment
image

@andchiind andchiind force-pushed the 944-set-inspection-freq branch 3 times, most recently from 0aa270b to e9d212c Compare October 17, 2023 10:17
@andchiind andchiind force-pushed the 944-set-inspection-freq branch from 41d8aab to 9ea6225 Compare October 18, 2023 10:46
@andchiind andchiind force-pushed the 944-set-inspection-freq branch 2 times, most recently from 9d06f78 to 2d05ea5 Compare October 18, 2023 11:29
@andchiind andchiind force-pushed the 944-set-inspection-freq branch 3 times, most recently from f981c49 to b6f2adc Compare October 20, 2023 13:36
mrica-equinor
mrica-equinor requested changes Oct 23, 2023
View reviewed changes
@andchiind andchiind force-pushed the 944-set-inspection-freq branch from b6f2adc to 544648d Compare October 30, 2023 14:55
@andchiind andchiind force-pushed the 944-set-inspection-freq branch from 544648d to 64cea5c Compare October 30, 2023 14:57
@andchiind andchiind force-pushed the 944-set-inspection-freq branch 2 times, most recently from ff61f5f to 556c565 Compare November 7, 2023 12:57
@mrica-equinor mrica-equinor force-pushed the 944-set-inspection-freq branch 2 times, most recently from 45bafde to a0f8288 Compare November 8, 2023 14:03
@mrica-equinor mrica-equinor force-pushed the 944-set-inspection-freq branch from a0f8288 to 258c804 Compare November 8, 2023 14:04
mrica-equinor
mrica-equinor approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andchiind andchiind merged commit cc814b8 into equinor:main Nov 8, 2023
@andchiind andchiind deleted the 944-set-inspection-freq branch November 8, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol left review comments

@mrica-equinor mrica-equinor mrica-equinor approved these changes

Assignees

@andchiind andchiind

Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to edit mission definition inspection frequency
3 participants
@andchiind @Eddasol @mrica-equinor