Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mission order #1058

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix mission order #1058

merged 1 commit into from
Oct 19, 2023

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Oct 13, 2023

No description provided.

@Eddasol
Copy link
Contributor Author

Eddasol commented Oct 13, 2023

image
Removing orderBy fixes the ordering but causes this warning

@Eddasol Eddasol marked this pull request as ready for review October 13, 2023 12:01
@Eddasol Eddasol self-assigned this Oct 13, 2023
@Eddasol Eddasol added bug Something isn't working backend Backend related functionality labels Oct 13, 2023
@Eddasol Eddasol linked an issue Oct 13, 2023 that may be closed by this pull request
Mission queue is no longer FIFO #1053
Closed
Christdej
Christdej reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to make the error go away some way, as they are normally there for a reason, if not we can add statements to ignore the warning

@Eddasol Eddasol force-pushed the fix-mission-order branch 4 times, most recently from 7b00409 to 5d00410 Compare October 13, 2023 14:02
@github-actions github-actions bot added the database-change Will require migration label Oct 13, 2023
@Eddasol Eddasol removed the database-change Will require migration label Oct 13, 2023
@equinor equinor deleted a comment from github-actions bot Oct 13, 2023
@Eddasol Eddasol force-pushed the fix-mission-order branch 3 times, most recently from 3e0c55a to a7a0218 Compare October 19, 2023 07:55
Christdej
Christdej requested changes Oct 19, 2023
View reviewed changes
backend/api/Utilities/PagedList.cs Outdated Show resolved Hide resolved
@Eddasol Eddasol merged commit a3e9e87 into equinor:main Oct 19, 2023
7 checks passed
@Eddasol Eddasol deleted the fix-mission-order branch October 19, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

@andchiind andchiind Awaiting requested review from andchiind

Assignees

@Eddasol Eddasol

Labels
backend Backend related functionality bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mission queue is no longer FIFO
3 participants
@Eddasol @andchiind @Christdej