Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual indexing for the mission queue #1066

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Visual indexing for the mission queue #1066

merged 2 commits into from
Oct 31, 2023

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Oct 16, 2023

No description provided.

@Eddasol Eddasol added frontend Frontend related functionality improvement Improvement to existing functionality labels Oct 16, 2023
@Eddasol Eddasol force-pushed the checkbox-to-index branch 2 times, most recently from b291a8d to b5a129c Compare October 18, 2023 06:36
@Eddasol Eddasol marked this pull request as ready for review October 18, 2023 06:36
@Eddasol Eddasol force-pushed the checkbox-to-index branch 3 times, most recently from 1128305 to e084ea0 Compare October 23, 2023 08:52
@Eddasol Eddasol force-pushed the checkbox-to-index branch 4 times, most recently from f260d31 to fb5ccf9 Compare October 24, 2023 13:52
@Eddasol Eddasol requested a review from mrica-equinor October 24, 2023 13:52
@Eddasol Eddasol force-pushed the checkbox-to-index branch 2 times, most recently from 112c66f to 90253e2 Compare October 27, 2023 07:14
andchiind
andchiind reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for using several comments for multiline suggestions, I couldn’t figure out how to do in on mobile.

frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx Outdated Show resolved Hide resolved
frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx Outdated Show resolved Hide resolved
frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx Outdated Show resolved Hide resolved
frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx Outdated Show resolved Hide resolved
frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx Outdated Show resolved Hide resolved
@Eddasol Eddasol force-pushed the checkbox-to-index branch 2 times, most recently from f5a18fd to dcd3592 Compare October 27, 2023 13:45
@Eddasol Eddasol requested a review from andchiind October 27, 2023 13:46
@Eddasol Eddasol force-pushed the checkbox-to-index branch 2 times, most recently from 19cafe3 to 9951bc1 Compare October 27, 2023 14:25
@Eddasol Eddasol requested a review from mrica-equinor October 30, 2023 09:27
mrica-equinor
mrica-equinor approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Eddasol Eddasol merged commit 00bb821 into equinor:main Oct 31, 2023
7 checks passed
@Eddasol Eddasol deleted the checkbox-to-index branch October 31, 2023 07:20
@Eddasol Eddasol linked an issue Oct 31, 2023 that may be closed by this pull request
Change checkbox to numbering for missions in queue #1059
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrica-equinor mrica-equinor mrica-equinor approved these changes

@UsamaEquinorAFK UsamaEquinorAFK Awaiting requested review from UsamaEquinorAFK

@andchiind andchiind Awaiting requested review from andchiind

Assignees

@Eddasol Eddasol

@prasm313 prasm313

Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change checkbox to numbering for missions in queue
4 participants
@Eddasol @andchiind @mrica-equinor @prasm313