Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add timer functionality #1083

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Oct 26, 2023

Was not able to identify the issue but made a small refactor to improve readability

@aeshub aeshub added the improvement Improvement to existing functionality label Oct 26, 2023
@aeshub aeshub self-assigned this Oct 26, 2023
@aeshub aeshub force-pushed the investigate-robot-timeouts branch from fe7a174 to b3bc46b Compare October 26, 2023 14:10
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only potential comments are subjective ones related to including braces when inlining if statements, as mentioned in #1085

@aeshub aeshub force-pushed the investigate-robot-timeouts branch from b3bc46b to df04f7e Compare October 27, 2023 10:56
@aeshub aeshub merged commit d5dcecc into equinor:main Oct 27, 2023
7 checks passed
@aeshub aeshub deleted the investigate-robot-timeouts branch October 27, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants