Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrency issues for updating robot object #1092

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Fix concurrency issues for updating robot object #1092

merged 9 commits into from
Nov 2, 2023

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Oct 30, 2023 •
edited
Loading

Closes #1089

@aeshub aeshub added the bug Something isn't working label Oct 30, 2023
@aeshub aeshub self-assigned this Oct 30, 2023
@aeshub aeshub marked this pull request as draft October 30, 2023 09:46
@github-actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@aeshub aeshub force-pushed the fix-missions-being-set-to-wrong-status branch 5 times, most recently from 3134b34 to 6837903 Compare November 1, 2023 13:17
@aeshub aeshub marked this pull request as ready for review November 1, 2023 13:23
@aeshub aeshub changed the title Fix missions being set to wrong status Fix concurrency issues for updating robot object Nov 1, 2023
@aeshub aeshub force-pushed the fix-missions-being-set-to-wrong-status branch from 6837903 to c3a5b67 Compare November 2, 2023 08:49
aeshub added 8 commits November 2, 2023 10:00
@aeshub
Log mission run id over mission definition
32cc36a
@aeshub
Refactor adding pose entires into service
50e561d
@aeshub
Move log statement of mission completed
03ad6f1 
The log statement was in a location where it would always be called
even if a mission had in fact not been completed yet.
@aeshub
Remove handling of orphaned mission runs
b63440c 
This handling should no longer be required in the robot controller. It
was also causing previously finished mission runs to be set as failed
even though they had succeeded as the current mission for the robot had
not been reset yet.
@aeshub
Close timer when it fails to be added to dict
9710481
@aeshub
Set robot object to unchanged on update
3793b7f
@aeshub
Move time consuming task to end of function
f5c9bc1
@aeshub
Fix faulty paranthesis on failing test
d963446
@aeshub aeshub force-pushed the fix-missions-being-set-to-wrong-status branch from c3a5b67 to d963446 Compare November 2, 2023 09:09
Christdej
Christdej approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub aeshub merged commit 3c05b7f into equinor:main Nov 2, 2023
8 checks passed
@aeshub aeshub deleted the fix-missions-being-set-to-wrong-status branch November 2, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysand oysand oysand left review comments

@Christdej Christdej Christdej approved these changes

Assignees

@aeshub aeshub

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve race condition in read and write to robot object
3 participants
@aeshub @oysand @Christdej