Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InspectionFindings endpoint to Flotilla API #1150

Merged
merged 8 commits into from
Nov 15, 2023
Merged

Add InspectionFindings endpoint to Flotilla API #1150

merged 8 commits into from
Nov 15, 2023

Conversation

UsamaEquinorAFK
Copy link
Contributor

@UsamaEquinorAFK UsamaEquinorAFK commented Nov 9, 2023 •
edited
Loading

Using IsarStepId to add InspectionFindings under Inspections which is owned by Tasks which is owned by MissionRun.

The above statement is now a lie, they are no longer owned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@UsamaEquinorAFK UsamaEquinorAFK mentioned this pull request Nov 10, 2023
Closed
@UsamaEquinorAFK UsamaEquinorAFK force-pushed the insfin branch 2 times, most recently from a462b86 to 940f5d5 Compare November 10, 2023 15:30
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Nov 10, 2023
@UsamaEquinorAFK UsamaEquinorAFK force-pushed the insfin branch 2 times, most recently from c93e1ba to c90fb36 Compare November 13, 2023 09:40
Christdej
Christdej requested changes Nov 13, 2023
View reviewed changes
backend/api/Database/Models/InspectionFindings.cs Show resolved Hide resolved
backend/api/Database/Models/InspectionFindings.cs Outdated Show resolved Hide resolved
backend/api/Program.cs Outdated Show resolved Hide resolved
backend/api/Controllers/InspectionFindingsController.cs Outdated Show resolved Hide resolved
@UsamaEquinorAFK UsamaEquinorAFK force-pushed the insfin branch 3 times, most recently from 542aed5 to 1567632 Compare November 13, 2023 10:50
@UsamaEquinorAFK UsamaEquinorAFK requested review from Christdej and removed request for andchiind and oysand November 13, 2023 11:00
@UsamaEquinorAFK UsamaEquinorAFK removed the request for review from mrica-equinor November 13, 2023 11:01
@UsamaEquinorAFK UsamaEquinorAFK force-pushed the insfin branch 2 times, most recently from dfa62ae to f611c63 Compare November 13, 2023 12:49
Christdej
Christdej requested changes Nov 13, 2023
View reviewed changes
backend/api/Controllers/InspectionFindingsController.cs Outdated Show resolved Hide resolved
backend/api/Controllers/InspectionFindingsController.cs Outdated Show resolved Hide resolved
backend/api/Controllers/InspectionFindingsController.cs Outdated Show resolved Hide resolved
backend/api/Controllers/InspectionFindingsController.cs Outdated Show resolved Hide resolved
backend/api/Database/Models/InspectionFindings.cs Outdated Show resolved Hide resolved
backend/api/Database/Models/InspectionFindings.cs Outdated Show resolved Hide resolved
@UsamaEquinorAFK UsamaEquinorAFK force-pushed the insfin branch 3 times, most recently from 92e4a2b to e3f4bb0 Compare November 13, 2023 19:12
Christdej
Christdej requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the previous comments

Christdej
Christdej approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UsamaEquinorAFK
Copy link
Contributor Author

Just rebased afterwards now new work added.

@UsamaEquinorAFK UsamaEquinorAFK removed the request for review from aeshub November 15, 2023 09:55
@UsamaEquinorAFK UsamaEquinorAFK merged commit f63ac1e into equinor:main Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeshub aeshub aeshub left review comments

@Christdej Christdej Christdej approved these changes

Assignees
No one assigned
Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UsamaEquinorAFK @aeshub @Christdej @MuhammadUsama-afk-equinor