Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop mission if robot is idle #1152

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

Afonso-2403
Copy link
Contributor

@Afonso-2403 Afonso-2403 commented Nov 9, 2023

If the robot is reported as idle from ISAR, stopping a mission should not crash

@Afonso-2403 Afonso-2403 added the backend Backend related functionality label Nov 9, 2023
@Afonso-2403 Afonso-2403 requested a review from aeshub November 9, 2023 16:35
@Afonso-2403 Afonso-2403 self-assigned this Nov 9, 2023
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If the robot is reported as idle from ISAR, stopping a mission should not crash
@Afonso-2403
Copy link
Contributor Author

This solution should be temporary, created an issue in ISAR to address this problem

@Afonso-2403 Afonso-2403 merged commit bf5ae79 into equinor:main Nov 10, 2023
7 checks passed
@Afonso-2403 Afonso-2403 deleted the stop-in-idle branch November 10, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants