Make Inspection and MissionTask not owned entities
#1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeshub
added
bug
|
🔔 Migrations changes detected 🔔 |
aeshub
force-pushed
the
2-ongoing-missions
branch
from
85631e3 to
2e16f5c
Compare
Afonso-2403
reviewed
Nov 10, 2023
tsundvoll
reviewed
Nov 10, 2023
aeshub
force-pushed
the
2-ongoing-missions
branch
2 times, most recently
from
02c1fa4 to
304a45a
Compare
This means the Inspection object may be accessed directly on the context and allows us to directly update it without running a full update of the mission run.
The mission task entity is no longer owned by mission run. This allows updating mission task directly rather than updating all of the mission run.
|
/UpdateDatabase |
|
👀 Running migration command... 👀 |
|
✨ Successfully ran migration command! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As these were owned by
MissionRunthe only method of updating the status of each of them was to update the entireMissionRun. As this happens in three parallel event handlers these were overwriting eachother.Closes #1141