Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor inspection findings #1189

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Refactor inspection findings #1189

merged 4 commits into from
Nov 16, 2023

Conversation

UsamaEquinorAFK
Copy link
Contributor

@UsamaEquinorAFK UsamaEquinorAFK commented Nov 16, 2023 •
edited
Loading

Closes #1186

@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@UsamaEquinorAFK UsamaEquinorAFK self-assigned this Nov 16, 2023
tsundvoll
tsundvoll approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@tsundvoll tsundvoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Nov 16, 2023
@UsamaEquinorAFK
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@UsamaEquinorAFK UsamaEquinorAFK merged commit 3e3982f into equinor:main Nov 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsundvoll tsundvoll tsundvoll approved these changes

Assignees

@UsamaEquinorAFK UsamaEquinorAFK

Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
3 participants
@UsamaEquinorAFK @tsundvoll @MuhammadUsama-afk-equinor