Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve appearance of no missions available dialog #1196

Conversation

mrica-equinor
Copy link
Contributor

@mrica-equinor mrica-equinor commented Nov 17, 2023

Closes #1183

@mrica-equinor mrica-equinor self-assigned this Nov 17, 2023
@mrica-equinor mrica-equinor added improvement Improvement to existing functionality frontend Frontend related functionality labels Nov 17, 2023
Comment on lines -28 to -29
<Dialog open={true} isDismissable>
<StyledAutoComplete>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@@ -24,20 +21,21 @@ const StyledMissionSection = styled.div`
export const NoMissionsDialog = ({ closeDialog }: { closeDialog: () => void }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add this change while updating the file?

const StyledMissionSection = styled.div`
    display: flex;
    justify-content: end;
    gap: 10px;

Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged after fixing Edda's comments

@mrica-equinor mrica-equinor force-pushed the fix-no-missions-in-installation-dialog branch from 3c1f456 to 8385edc Compare December 12, 2023 13:54
@mrica-equinor mrica-equinor merged commit d203b53 into equinor:main Dec 12, 2023
8 checks passed
@mrica-equinor mrica-equinor deleted the fix-no-missions-in-installation-dialog branch May 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No mission for installation placeholder
3 participants