Refactor pressure and battery display #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
added
improvement
andchiind
force-pushed
the
rb-pressure
branch
from
1bb1f72 to
093d3b9
Compare
|
Is this also addressed here ? Refactor BatteryStatusView#1136 |
andchiind
force-pushed
the
rb-pressure
branch
2 times, most recently
from
2af721c to
a5da82a
Compare
andchiind
force-pushed
the
rb-pressure
branch
from
a5da82a to
7e02ed6
Compare
Christdej
reviewed
Nov 23, 2023
| case batteryLevel <= 10: | ||
| return Icons.BatteryAlert |
There was a problem hiding this comment.
Did we get rid of the BatteryCharging case because we have no way of telling that the battery is charging or an other reason?
There was a problem hiding this comment.
It's wasn't implemented, it was always being used BatteryStatus.Normal
mrica-equinor
force-pushed
the
rb-pressure
branch
from
91f2a27 to
d45b62b
Compare
mrica-equinor
force-pushed
the
rb-pressure
branch
from
d45b62b to
498b99e
Compare
andchiind
force-pushed
the
rb-pressure
branch
from
498b99e to
a68a301
Compare
andchiind
force-pushed
the
rb-pressure
branch
from
b423284 to
0990aba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1136