Refactor naming of type of mission tasks for the case of return to home #1373
Conversation
|
🔔 Changes in database folder detected 🔔 |
mrica-equinor
added
backend
| @@ -203,6 +203,6 @@ public enum MissionTaskType | |||
| { | |||
| Inspection, | |||
| Localization, | |||
| DriveTo | |||
| ReturnHome | |||
There was a problem hiding this comment.
Does this remove the ability to have DriveTo tasks, ie. tasks where we tell the robot to go somewhere, but we don't give it a target? I think there are several use-cases for these, and DriveTo is already supported in some Isar implementations. Could we instead add a new task type?
There was a problem hiding this comment.
I checked this with Afonso, DriveTo was created specifcally for the return to home functionality and it is not used anywhere in the code that is not related to return to home. At the time he wanted to change the name but went on vacation/offshore before he could do the refactor
There was a problem hiding this comment.
That is odd, since missions from echo use it in other parts of their missions. I think we may need to have a bigger discussion around this.
There was a problem hiding this comment.
Sorry, it seems I have misunderstood. I see now that this renaming will not affect the naming in the IsarTask
| @@ -203,6 +203,6 @@ public enum MissionTaskType | |||
| { | |||
| Inspection, | |||
| Localization, | |||
| DriveTo | |||
| ReturnHome | |||
There was a problem hiding this comment.
Sorry, it seems I have misunderstood. I see now that this renaming will not affect the naming in the IsarTask
mrica-equinor
force-pushed
the
1350-cancel-return-to-home
branch
2 times, most recently
from
e010488 to
9732c0c
Compare
mrica-equinor
force-pushed
the
1350-cancel-return-to-home
branch
from
9732c0c to
3751a6f
Compare
|
🔔 Migrations changes detected 🔔 |
|
/UpdateDatabase |
|
👀 Running migration command... 👀 |
|
✨ Successfully ran migration command! ✨ |
Closes #1350