Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve send robots to safe zone during localization mission #1470

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Improve send robots to safe zone during localization mission #1470

merged 5 commits into from
Mar 22, 2024

Conversation

mrica-equinor
Copy link
Contributor

Closes #1461

@mrica-equinor mrica-equinor self-assigned this Mar 13, 2024
@mrica-equinor mrica-equinor added backend Backend related functionality improvement Improvement to existing functionality labels Mar 13, 2024
andchiind
andchiind approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't managed to make it fail, LGTM

@mrica-equinor mrica-equinor force-pushed the improve-send-robots-safe-zone-button branch from 705ee8a to 48a9e81 Compare March 14, 2024 12:49
@andchiind andchiind force-pushed the improve-send-robots-safe-zone-button branch from 48a9e81 to 705ee8a Compare March 14, 2024 13:37
@mrica-equinor mrica-equinor force-pushed the improve-send-robots-safe-zone-button branch from 705ee8a to cf22d6b Compare March 15, 2024 09:10
oysand
oysand approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oysand oysand self-requested a review March 19, 2024 07:36
oysand
oysand requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, added for wrong PR. Still need the tests discussed

@mrica-equinor mrica-equinor force-pushed the improve-send-robots-safe-zone-button branch 3 times, most recently from dbb9336 to c392b29 Compare March 20, 2024 15:04
@mrica-equinor mrica-equinor force-pushed the improve-send-robots-safe-zone-button branch from c392b29 to 0b3922b Compare March 21, 2024 14:21
oysand
oysand approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrica-equinor mrica-equinor force-pushed the improve-send-robots-safe-zone-button branch from 0b3922b to c052b98 Compare March 22, 2024 10:59
@mrica-equinor mrica-equinor merged commit 52c6bb7 into equinor:main Mar 22, 2024
10 checks passed
@mrica-equinor mrica-equinor deleted the improve-send-robots-safe-zone-button branch May 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsundvoll tsundvoll tsundvoll approved these changes

@oysand oysand oysand approved these changes

@andchiind andchiind andchiind approved these changes

Assignees

@mrica-equinor mrica-equinor

Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking the send robots to safe zone button should always freeze the mission queue
4 participants
@mrica-equinor @andchiind @oysand @tsundvoll